-
Notifications
You must be signed in to change notification settings - Fork 628
Integrate LLVM at 21473462f762a9a2d3140eb8ecaea034f83d9a7c #4245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@penguin-wwy @qingyunqu While integrating LLVM, some errors related to StableHlo were encountered. It seems StableHlo also has to be updated. Can you please let me know what the status is for that? |
LLVM has modified the signatures of some interfaces llvm/llvm-project#144636, so stablehlo needs to update like this openxla/stablehlo#2824 or make similar changes. However, stablehlo also depends on updates from xla, so it cannot be merged for now. |
Hi @penguin-wwy, can you please let us know when this issue will be fixed? It's already been 2 weeks. |
I have submitted a new fix to stablehlo, but there has been no response yet. |
Okay. |
@vivekkhandelwal1 The commit has been merged. Please update stablehlo to the latest version. |
c7fdcbf
to
e7095c2
Compare
Hi @penguin-wwy, can you please review it now? |
Update LLVM to llvm/llvm-project@2147346
Update StableHLO to openxla/stablehlo@9018c68.
This commit also moves 2 of the tests that were failing earlier from the fail to the crash set.
Signed-off-by: Vivek Khandelwal [email protected]