Skip to content

Integrate LLVM at 21473462f762a9a2d3140eb8ecaea034f83d9a7c #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025

Conversation

vivekkhandelwal1
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 commented Jun 30, 2025

Update LLVM to llvm/llvm-project@2147346

Update StableHLO to openxla/stablehlo@9018c68.

This commit also moves 2 of the tests that were failing earlier from the fail to the crash set.

Signed-off-by: Vivek Khandelwal [email protected]

@vivekkhandelwal1
Copy link
Collaborator Author

@penguin-wwy @qingyunqu While integrating LLVM, some errors related to StableHlo were encountered. It seems StableHlo also has to be updated. Can you please let me know what the status is for that?

@penguin-wwy
Copy link
Collaborator

LLVM has modified the signatures of some interfaces llvm/llvm-project#144636, so stablehlo needs to update like this openxla/stablehlo#2824 or make similar changes. However, stablehlo also depends on updates from xla, so it cannot be merged for now.

@vivekkhandelwal1
Copy link
Collaborator Author

Hi @penguin-wwy, can you please let us know when this issue will be fixed? It's already been 2 weeks.

@penguin-wwy
Copy link
Collaborator

I have submitted a new fix to stablehlo, but there has been no response yet.

@vivekkhandelwal1
Copy link
Collaborator Author

I have submitted a new fix to stablehlo, but there has been no response yet.

Okay.

@penguin-wwy
Copy link
Collaborator

I have submitted a new fix to stablehlo, but there has been no response yet.

@vivekkhandelwal1 The commit has been merged. Please update stablehlo to the latest version.

@vivekkhandelwal1 vivekkhandelwal1 changed the title Integrate LLVM at f5c62ee0fa0466382cb11f6fad80d323b0fca057 Integrate LLVM at 21473462f762a9a2d3140eb8ecaea034f83d9a7c Aug 13, 2025
@vivekkhandelwal1
Copy link
Collaborator Author

I have submitted a new fix to stablehlo, but there has been no response yet.

@vivekkhandelwal1 The commit has been merged. Please update stablehlo to the latest version.

Hi @penguin-wwy, can you please review it now?

@vivekkhandelwal1 vivekkhandelwal1 merged commit d7e3484 into llvm:main Aug 13, 2025
3 checks passed
@vivekkhandelwal1 vivekkhandelwal1 deleted the bump-llvm branch August 13, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants